Bug 187991 – PaintingData' has no member named 'lightVector' on ARM_NEON

• Component: WebCore Misc.
• Status: RESOLVED CONFIGURATION CHANGED

[Hongxu Jia]

In file included from /home/wrlbuild/builds/builds-9ba2c4db-26fe-412a-a205-c45e89dcf35d/wrlinux-std-sato_beaglebone-yocto_world_18/tmp-glibc/work/cortexa8hf-neon-wrs-linux-gnueabi/webkitgtk
/2.20.3-r0/webkitgtk-2.20.3/Source/WebCore/platform/graphics/filters/FELighting.cpp:32,
                 from DerivedSources/WebCore/unified-sources/UnifiedSource349.cpp:4:
/home/wrlbuild/builds/builds-9ba2c4db-26fe-412a-a205-c45e89dcf35d/wrlinux-std-sato_beaglebone-yocto_world_18/tmp-glibc/work/cortexa8hf-neon-wrs-linux-gnueabi/webkitgtk/2.20.3-r0/webkitgtk-2.20.3/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h: In member function 'void WebCore::FELighting::platformApplyNeon(c
onst WebCore::FELighting::LightingData&, const WebCore::LightSource::PaintingData&)':
/home/wrlbuild/builds/builds-9ba2c4db-26fe-412a-a205-c45e89dcf35d/wrlinux-std-sato_beaglebone-yocto_world_18/tmp-glibc/work/cortexa8hf-neon-wrs-linux-gnueabi/webkitgtk/2.20.3-r0/webkitgtk-2.20.3/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:98:49: warning: requested alignment 16 is larger than 8 [-Wattributes]
     alignas(16) FELightingFloatArgumentsForNeon floatArguments;
                 
                                ^~~~~~~~~~~~~~
/home/wrlbuild/builds/builds-9ba2c4db-26fe-412a-a205-c45e89dcf35d/wrlinux-std-sato_beaglebone-yocto_world_18/tmp-glibc/work/cortexa8hf-neon-wrs-linux-gnueabi/webkitgtk/2.20.3-r0/webkitgtk-2.20.3/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:147:46: error: 'const struct WebCore::LightSource::PaintingData' has no member named 'lightVector'; did you mean 'directionVector'?
         floatArguments.lightX = paintingData.lightVector.x(
);
                                              ^~~~~~~~~~~
                                              directionVector
/home/wrlbuild/builds/builds-9ba2c4db-26fe-412a-a205-c45e89dcf35d/wrlinux-std-sato_beaglebone-yocto_world_18/tmp-glibc/work/cortexa8hf-neon-wrs-linux-gnueabi/webkitgtk/2.20.3-r0/webkitgtk-2.20.3/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:148:46: error: 'const struct WebCore::LightSource::PaintingData' has no member named 'lightVector'; did you mean 'di
rectionVector'?
         floatArguments.lightY = paintingData.lightVector.y();
                                              ^~~~~~~~~~~
                                              directionVector
/home/wrlbuild/builds/builds-9ba2c4db-26fe-412a-a205-c45e89dcf35d/wrlinux-std-sato_beaglebone-yocto_world_18/tmp-glibc/work/cortexa8hf-neon-wrs-linux-gnueabi/webkitgtk/2.20.3-r0/webkitgtk-2.20.3/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:149:46: error: 'const struct WebCore::Li
ghtSource::PaintingData' has no member named 'lightVector'; did you mean 'directionVector'?
         floatArguments.lightZ = paintingData.lightVector.z();
                                              ^~~~~~~~~~~
                                              directionVector

[Hongxu Jia]

    Since the following patch applied in upstream webkitgtk
    ...
    commit 1a55d8c685b3e5b4dbeda202009e7527aa59eadd
    Author: [e-mail] <[e-mail]@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
    Date:   Thu Nov 23 22:20:09 2017 +0000
    
        FELighting cleanup and optimization
        https://bugs.webkit.org/show_bug.cgi?id=179933
    ...
    
    It missed to tweak `paintingData.lightVector' which caused
    PaintingData' has no member named 'lightVector' on ARM_NEON
    (beaglebone)

[Hongxu Jia]

Created attachment 345748 [details]
Patch

[EWS Watchlist]

Attachment 345748 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Hongxu Jia]

Created attachment 345749 [details]
Patch

[EWS Watchlist]

Comment on attachment 345749 [details]
Patch

Attachment 345749 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8648363

New failing tests:
fast/repaint/canvas-object-fit.html

[EWS Watchlist]

Created attachment 345750 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 345749 [details]
Patch

Attachment 345749 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8652701

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

[EWS Watchlist]

Created attachment 345778 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Adrian Perez]

The NEON optimizations have been reworked a while back. The source
source files mentioned in the build error log no longer exist, so I
think we can close this.