Bug 187964

Summary: ImageBitmap should report its memory cost
Product: WebKit Reporter: Zan Dobersek <zan>
Component: CanvasAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, kkinnunen, kondapallykalyan, Ms2ger, sabouhallawa, simon.fraser, wayne.langman, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232139
https://bugs.webkit.org/show_bug.cgi?id=232357
Bug Depends on:    
Bug Blocks: 229825    
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2018-07-24 10:53:17 PDT
ImageBitmap should report its memory cost
Attachments
Patch (3.04 KB, patch)
2018-07-24 10:59 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (4.40 KB, patch)
2021-10-22 03:40 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-07-24 10:59:52 PDT
Created attachment 345690 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-07-24 16:00:59 PDT
Comment on attachment 345690 [details] Patch This should be testable somehow, right?
Zan Dobersek
Comment 3 2018-07-25 10:53:05 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 345690 [details] > Patch > > This should be testable somehow, right? I don't know, I can't find a comparable test for e.g. HTMLCanvasElement. The changes here primarily increase the reported memory cost of ImageBitmap objects, bringing down the delay in which GC is triggered. This helps destroying stale ImageBitmaps and underlying pixel data. Any pointers about how to test this are welcome.
Kimmo Kinnunen
Comment 4 2021-10-22 03:40:41 PDT
Created attachment 442145 [details] Patch
Kimmo Kinnunen
Comment 5 2021-10-22 03:44:26 PDT
Taking the liberty to taking the bug, feel free to comment if you disagree. For the test I could only find internals.memoryInfo() but didn't feel confident it was working since none of the tests use it.. I can add the test but I uploaded the patch if it's useful for bug 232139
Radar WebKit Bug Importer
Comment 6 2021-10-22 07:11:58 PDT
<rdar://problem/84548359>
EWS
Comment 7 2021-10-24 23:47:57 PDT
Committed r284772 (243481@main): <https://commits.webkit.org/243481@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442145 [details].
Simon Fraser (smfr)
Comment 8 2024-11-01 09:53:33 PDT
*** Bug 229825 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.