| Summary: | [JSC] GetByIdVariant and InByIdVariant do not need slot base if they are not "hit" variants | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 164904 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2018-07-22 11:02:25 PDT
Created attachment 345540 [details]
Patch
WIP: comments are welcome!
(In reply to Yusuke Suzuki from comment #0) > [JSC] GetByIdVariant and InByIdVariant do not need slot base if they are not > "hit" variants Seems reasonable I've ensured that this patch fixes performance regression in SixSpeed/destructuring-es6.
Previously, this bug makes some statuses "Slow", and emits "GetById" DFG node. And it breaks OAS.
baseline patched
destructuring.es6 322.4751+-2.8517 ^ 96.2486+-5.5259 ^ definitely 3.3504x faster
https://arewefastyet.com/#machine=29&view=single&suite=six-speed&subtest=destructuring-es6
Created attachment 345541 [details]
Patch
OK, the patch is ready. Comment on attachment 345541 [details]
Patch
r=me
seems reasonable
Committed r234090: <https://trac.webkit.org/changeset/234090> |