Bug 187879

Summary: [LFC][IFC] Add verification for inline text runs.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch koivisto: review+

alan
Reported 2018-07-20 21:23:57 PDT
against simple and complex runs.
Attachments
Patch (13.14 KB, patch)
2018-07-20 21:26 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.16 KB, patch)
2018-07-20 21:33 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.16 KB, patch)
2018-07-20 21:37 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.16 KB, patch)
2018-07-20 21:40 PDT, alan 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-07-20 21:26:01 PDT
Created attachment 345499 [details] Patch
alan
Comment 2 2018-07-20 21:33:09 PDT
Created attachment 345500 [details] Patch
EWS Watchlist
Comment 3 2018-07-20 21:36:20 PDT
Attachment 345500 [details] did not pass style-queue: ERROR: Source/WebCore/layout/inlineformatting/InlineFormattingState.h:50: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
alan
Comment 4 2018-07-20 21:37:58 PDT
Created attachment 345501 [details] Patch
EWS Watchlist
Comment 5 2018-07-20 21:39:22 PDT
Attachment 345501 [details] did not pass style-queue: ERROR: Source/WebCore/layout/inlineformatting/InlineFormattingState.h:50: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
alan
Comment 6 2018-07-20 21:40:30 PDT
Created attachment 345502 [details] Patch
alan
Comment 7 2018-07-21 11:49:29 PDT
Committed r234085: <https://trac.webkit.org/changeset/234085>
Radar WebKit Bug Importer
Comment 8 2018-07-21 11:50:19 PDT
<rdar://problem/42467004>
Note You need to log in before you can comment on or make changes to this bug.