Bug 187865

Summary: Refactor the RenderLayer composited phases painting into a separate function
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: NEW    
Severity: Normal CC: bfulgham, ews-watchlist, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 187841    
Bug Blocks: 187898    
Attachments:
Description Flags
Patch for EWS
ews-watchlist: commit-queue-
Patch for Review
none
Archive of layout-test-results from ews200 for win-future none

Said Abou-Hallawa
Reported 2018-07-20 10:56:39 PDT
The plan is to make RenderLayer::paintLayerContents() choose between different implementations for painting the composited phases. The first implementation is the existing one: multiple passes into the drawing GraphicsContext. In the following patch, a new implementation will be introduced: multiple passes into multiple DisplayLists. Then this implementation will be changed to be: single pass into multiple DisplayLists.
Attachments
Patch for EWS (267.97 KB, patch)
2018-07-20 11:05 PDT, Said Abou-Hallawa 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Patch for Review (13.25 KB, patch)
2018-07-20 12:18 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (13.00 MB, application/zip)
2018-07-20 13:58 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2018-07-20 11:05:10 PDT
Created attachment 345462 [details] Patch for EWS
Said Abou-Hallawa
Comment 2 2018-07-20 12:18:49 PDT
Created attachment 345473 [details] Patch for Review
EWS Watchlist
Comment 3 2018-07-20 13:58:00 PDT
Comment on attachment 345462 [details] Patch for EWS Attachment 345462 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8602333 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
EWS Watchlist
Comment 4 2018-07-20 13:58:12 PDT
Created attachment 345480 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Radar WebKit Bug Importer
Comment 5 2018-08-06 16:37:04 PDT
<rdar://problem/42986513>
Note You need to log in before you can comment on or make changes to this bug.