Bug 187817

Summary:

Teach the AWS Lambda to use the [minified]-platforms database

Product:

WebKit

Reporter:

Lucas Forschler <lforschler>

Component:

Tools / Tests

Assignee:

Lucas Forschler <lforschler>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ddkilzer, dewei_zhu, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 11

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch for review	lforschler: commit-queue-
v2 patch to fix style errors.	ddkilzer: review+, lforschler: commit-queue-

Lucas Forschler

Reported 2018-07-19 13:16:39 PDT

When archives are uploaded to S3, we need to keep track of what platforms are available. We can easily do this with the current lambda function which parses the rest of the metadata.

Attachments
patch for review (3.49 KB, patch) 2018-07-19 13:19 PDT, Lucas Forschler	lforschler: commit-queue-	Details Formatted Diff Diff
v2 patch to fix style errors. (3.46 KB, patch) 2018-07-19 13:28 PDT, Lucas Forschler	ddkilzer: review+ lforschler: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-07-19 13:17:08 PDT

<rdar://problem/42396841>

Lucas Forschler

Comment 2 2018-07-19 13:19:06 PDT

Created attachment 345375 [details] patch for review

dewei_zhu

Comment 3 2018-07-19 13:20:56 PDT

Comment on attachment 345375 [details] patch for review looks good to me.

EWS Watchlist

Comment 4 2018-07-19 13:22:17 PDT

Attachment 345375 [details] did not pass style-queue: ERROR: Tools/WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:45: trailing whitespace [pep8/W291] [5] ERROR: Tools/WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:53: trailing whitespace [pep8/W291] [5] ERROR: Tools/WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:45: trailing whitespace [pep8/W291] [5] ERROR: Tools/WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:53: trailing whitespace [pep8/W291] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

Lucas Forschler

Comment 5 2018-07-19 13:28:35 PDT

Created attachment 345376 [details] v2 patch to fix style errors.

David Kilzer (:ddkilzer)

Comment 6 2018-07-19 16:32:26 PDT

Comment on attachment 345376 [details] v2 patch to fix style errors. rs=me

Lucas Forschler

Comment 7 2018-07-19 16:38:22 PDT

Committed revision 234016.

Aakash Jain

Comment 8 2018-07-19 16:42:25 PDT

Comment on attachment 345376 [details] v2 patch to fix style errors. looks good to me.

Note You need to log in before you can comment on or make changes to this bug.