Bug 187814

Summary: REGRESSION(r233969): ASSERT in -[WebAVPlayerLayer setVideoGravity:]
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, jeremyj-wk, jonlee, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews205 for win-future none

Description Jer Noble 2018-07-19 12:27:25 PDT
REGRESSION(r233969): ASSERT in -[WebAVPlayerLayer setVideoGravity:]
Comment 1 Jer Noble 2018-07-19 12:30:02 PDT
<rdar://problem/42391869>
Comment 2 Jer Noble 2018-07-19 12:30:05 PDT
Created attachment 345372 [details]
Patch
Comment 3 Sam Weinig 2018-07-19 13:31:11 PDT
Can this be tested?
Comment 4 Jer Noble 2018-07-19 16:16:25 PDT
(In reply to Sam Weinig from comment #3)
> Can this be tested?

We see this ASSERT happening in crash reports, but I haven't been able to reproduce the crash in WKTR or DTR. It looks like it may be a timing issue with AVKit that happens occasionally.
Comment 5 EWS Watchlist 2018-07-20 01:24:30 PDT
Comment on attachment 345372 [details]
Patch

Attachment 345372 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8596796

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 6 EWS Watchlist 2018-07-20 01:24:41 PDT
Created attachment 345434 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 WebKit Commit Bot 2018-07-20 09:51:14 PDT
Comment on attachment 345372 [details]
Patch

Clearing flags on attachment: 345372

Committed r234044: <https://trac.webkit.org/changeset/234044>
Comment 8 WebKit Commit Bot 2018-07-20 09:51:15 PDT
All reviewed patches have been landed.  Closing bug.