Summary: | ASSERTION !data.customElementReactionQueue() when creating custom element inside an SVG document | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||
Component: | DOM | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, rniwa, rwlbuis, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
URL: | https://w3c-test.org/custom-elements/parser/parser-uses-create-an-element-for-a-token-svg.svg | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=187319 | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 154907 | ||||||||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2018-07-19 08:25:35 PDT
Created attachment 345567 [details]
Patch
Comment on attachment 345567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345567&action=review > Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:787 > + if (!m_parsingFragment) Step 5 actually says it should happen if in addition the custom element definition is non-null (which is true in the repro case). Created attachment 346067 [details]
Patch
Created attachment 346070 [details]
Patch
Comment on attachment 346070 [details]
Patch
Will handle the custom element reaction stack push/pop in a separate bug.
ASSERTION has been removed in bug 188327 so I think we can just unskip the test now. However, the same logic as bug 188327 (special case for HTML fragment parsing) probably still needs to be implemented for the XML parser. Created attachment 346613 [details]
Patch
Comment on attachment 346613 [details] Patch Clearing flags on attachment: 346613 Committed r234591: <https://trac.webkit.org/changeset/234591> All reviewed patches have been landed. Closing bug. |