Summary: | Adjust WEBCORE_EXPORT annotations for LTO | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||||
Component: | WebCore Misc. | Assignee: | Keith Rollin <krollin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, ddkilzer, ews-watchlist, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=186944 | ||||||||
Attachments: |
|
Description
Keith Rollin
2018-07-18 14:19:44 PDT
Created attachment 345285 [details]
Patch
Attachment 345285 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/FourCC.h:33: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/IntPoint.h:73: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
Total errors found: 2 in 12 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 345285 [details] Patch Attachment 345285 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8584359 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html http/tests/preload/onload_event.html Created attachment 345338 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 345285 [details] Patch Clearing flags on attachment: 345285 Committed r233990: <https://trac.webkit.org/changeset/233990> All reviewed patches have been landed. Closing bug. |