Bug 187779

Summary: [WHLSL] The interpreter doesn't support boolean short-circuiting
Product: WebKit Reporter: Thomas Denney <tdenney>
Component: WebGPUAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dino, mmaxfield, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Thomas Denney
Reported 2018-07-18 13:52:07 PDT
The WHLSL specification states that the boolean operations && and || should support short-circuiting, i.e. in e1 && e2, e2 is only evaluated if e1 evaluates to true, and in e1 || e2, e2 is only evaluated if e1 evaluates to false. Currently the interpreter doesn't adhere to this behavior and evaluates both operands as && and || are implemented as functions that take a pair of boolean arguments.
Attachments
Patch (3.15 KB, patch)
2018-07-18 20:35 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thomas Denney
Comment 1 2018-07-18 20:35:30 PDT
Created attachment 345320 [details] Patch
WebKit Commit Bot
Comment 2 2018-07-19 13:42:26 PDT
Comment on attachment 345320 [details] Patch Clearing flags on attachment: 345320 Committed r234001: <https://trac.webkit.org/changeset/234001>
WebKit Commit Bot
Comment 3 2018-07-19 13:42:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-07-19 13:43:18 PDT
<rdar://problem/42398027>
Jer Noble
Comment 5 2018-07-20 15:35:12 PDT
*** Bug 186773 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.