Bug 187772

Summary: Web Inspector: REGRESSION(r232591): CodeMirrorEditor should not use a RegExp lineSeparator option
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Matt Baker
Reported 2018-07-18 10:59:25 PDT
Summary: CodeMirrorEditor should not use a RegExp lineSeparator option. Instead we should leave this option undefined. When no lineSeparator is specified, CodeMirror will effectively split lines on /\r\n?|\n/, but joins on \n when recreating the source text. Regressed in https://trac.webkit.org/changeset/232591.
Attachments
Patch (3.37 KB, patch)
2018-07-18 11:06 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2018-07-18 11:00:01 PDT
<rdar://problem/42331640>
Matt Baker
Comment 2 2018-07-18 11:06:27 PDT
Created attachment 345261 [details] Patch
Joseph Pecoraro
Comment 3 2018-07-18 11:12:52 PDT
Comment on attachment 345261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345261&action=review r=me > Source/WebInspectorUI/ChangeLog:15 > + it detects \n, \r\n, and \r. By specifying a regular expression we > + merely cause problems when CodeMirror uses the supplied lineSeparator > + when joining its array of lines together. Well that stinks.
Matt Baker
Comment 4 2018-07-18 11:14:12 PDT
Comment on attachment 345261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345261&action=review >> Source/WebInspectorUI/ChangeLog:15 >> + when joining its array of lines together. > > Well that stinks. Indeed.
WebKit Commit Bot
Comment 5 2018-07-18 11:40:21 PDT
Comment on attachment 345261 [details] Patch Clearing flags on attachment: 345261 Committed r233920: <https://trac.webkit.org/changeset/233920>
WebKit Commit Bot
Comment 6 2018-07-18 11:40:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.