Bug 187762

Summary: REGRESSION(r233830): http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party.html is failing
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: Tools / TestsAssignee: Alicia Boya García <aboya>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bugs-noreply, commit-queue, lforschler, ryanhaddad, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing
aboya: commit-queue-
Patch for landing none

Alicia Boya García
Reported 2018-07-18 07:44:17 PDT
The following tests are failing on GTK since r233830-233831: http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party.html http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html
Attachments
Patch for landing (4.23 KB, patch)
2018-07-18 11:02 PDT, Alicia Boya García 		aboya: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (2.45 KB, patch)
2019-10-09 11:39 PDT, Alicia Boya García 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alicia Boya García
Comment 1 2018-07-18 07:53:34 PDT
--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party-actual.txt @@ -16,4 +16,4 @@ -------- Frame: '<!--frame1-->' -------- -Cookies are: setAsFirstParty = value foo = bar +Cookies are: setAsFirstParty = value --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior-actual.txt @@ -15,4 +15,4 @@ -------- Frame: '<!--frame1-->' -------- -Cookies are: setAsFirstParty = value foo = bar +Cookies are: setAsFirstParty = value
Alicia Boya García
Comment 2 2018-07-18 07:54:12 PDT
The failure is present on Apple platforms too.
Alicia Boya García
Comment 3 2018-07-18 09:25:53 PDT
The regression was probably introduced in: Author: wilander@apple.com <wilander@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Sat Jul 14 01:07:38 2018 +0000 Flesh out WebSocket cookie tests to cover cookie policy for third-party resources https://bugs.webkit.org/show_bug.cgi?id=187541 <rdar://problem/42048729>
Alicia Boya García
Comment 4 2018-07-18 11:02:58 PDT
Created attachment 345258 [details] Patch for landing
Alicia Boya García
Comment 5 2018-07-18 11:04:54 PDT
(Tagged wrong bug to the patch, marked as obsolete.)
Alicia Boya García
Comment 6 2019-10-09 05:13:43 PDT
Passing in last runs, closing.
Alexey Proskuryakov
Comment 7 2019-10-09 08:55:52 PDT
Thank you for removing the root test expectation. Can these be removed now too? LayoutTests/platform/win/TestExpectations:4041:webkit.org/b/187762 http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party.html [ Pass ] LayoutTests/platform/wincairo/TestExpectations:980:http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party.html [ Pass Failure ]
Alicia Boya García
Comment 8 2019-10-09 11:39:10 PDT
Reopening to attach new patch.
Alicia Boya García
Comment 9 2019-10-09 11:39:13 PDT
Created attachment 380547 [details] Patch for landing
WebKit Commit Bot
Comment 10 2019-10-09 12:23:36 PDT
Comment on attachment 380547 [details] Patch for landing Clearing flags on attachment: 380547 Committed r250920: <https://trac.webkit.org/changeset/250920>
WebKit Commit Bot
Comment 11 2019-10-09 12:23:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2019-10-09 12:24:17 PDT
<rdar://problem/56125848>
Note You need to log in before you can comment on or make changes to this bug.