Bug 187747

Summary:

Fix the parsing of colors in attributed string tests, and make it possible to dump the typing attributes

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-sierra	none
Patch	none
Archive of layout-test-results from ews206 for win-future	none

Simon Fraser (smfr)

Reported 2018-07-17 21:44:36 PDT

Fix the parsing of colors in attributed string tests, and make it possible to dump the typing attributes

Attachments
Patch (44.43 KB, patch) 2018-07-17 21:47 PDT, Simon Fraser (smfr)	rniwa: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.36 MB, application/zip) 2018-07-17 22:54 PDT, EWS Watchlist	no flags	Details
Patch (65.55 KB, patch) 2018-07-17 23:10 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews206 for win-future (13.01 MB, application/zip) 2018-07-18 06:56 PDT, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2018-07-17 21:47:34 PDT

Created attachment 345224 [details] Patch

Radar WebKit Bug Importer

Comment 2 2018-07-17 21:48:17 PDT

<rdar://problem/42320838>

EWS Watchlist

Comment 3 2018-07-17 22:54:06 PDT

Comment on attachment 345224 [details] Patch Attachment 345224 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8571209 New failing tests: editing/mac/attributed-string/comment-cdata-section.html editing/mac/attributed-string/font-style-variant-effect.html editing/mac/attributed-string/font-weight.html editing/mac/attributed-string/letter-spacing.html editing/mac/attributed-string/vertical-align.html editing/mac/attributed-string/attributed-string-for-typing.html editing/mac/attributed-string/text-decorations.html editing/mac/attributed-string/font-size.html editing/mac/attributed-string/anchor-element.html editing/mac/attributed-string/basic.html

EWS Watchlist

Comment 4 2018-07-17 22:54:08 PDT

Created attachment 345225 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

Simon Fraser (smfr)

Comment 5 2018-07-17 23:10:43 PDT

Created attachment 345227 [details] Patch

EWS Watchlist

Comment 6 2018-07-18 06:56:27 PDT

Comment on attachment 345227 [details] Patch Attachment 345227 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8574153 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html

EWS Watchlist

Comment 7 2018-07-18 06:56:39 PDT

Created attachment 345242 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

WebKit Commit Bot

Comment 8 2018-07-18 08:55:40 PDT

Comment on attachment 345227 [details] Patch Clearing flags on attachment: 345227 Committed r233913: <https://trac.webkit.org/changeset/233913>

Note You need to log in before you can comment on or make changes to this bug.