Bug 187716

Summary: run-leaks should run leaks with --list (on Mojave)
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ews-watchlist, glenn, joepeck, lforschler, lingcherd_ho, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch lforschler: review+

Joseph Pecoraro
Reported 2018-07-16 16:20:11 PDT
run-leaks should run leaks with --list (on Mojave) or LeaksViewer should parse new format (ROOT leaks) I think currently on new enough macOS builds or with a new enough Xcode the leaks output will differ such that LeaksViewer's LeaksParserImpl would not be able to parse out individual leaks.
Attachments
proposed patch (9.06 KB, patch)
2018-08-31 10:27 PDT, Alexey Proskuryakov 		lforschler: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-07-16 16:20:49 PDT
<rdar://problem/42261676>
Joseph Pecoraro
Comment 2 2018-07-16 16:59:50 PDT
Also `parseLeaksOutput` in Tools/Scripts/run-leaks
Alexey Proskuryakov
Comment 3 2018-08-31 10:20:46 PDT
I don't think that parsing the new format is feasible without deep changes to LeaksViewer.
Alexey Proskuryakov
Comment 4 2018-08-31 10:27:22 PDT
Created attachment 348647 [details] proposed patch
Alexey Proskuryakov
Comment 5 2018-08-31 11:27:32 PDT
Hmm, I got 1.7 GB of memgraphs when running locally. We'll probably need custom aggressive pruning for leaks queue archives for this to be feasible.
Lucas Forschler
Comment 6 2018-09-04 12:14:10 PDT
Comment on attachment 348647 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=348647&action=review > Tools/ChangeLog:14 > + (runLeaks): Ad there is no way to test whether the new format is supported in advance, nit: Ad = Add?
Alexey Proskuryakov
Comment 7 2018-09-04 14:06:50 PDT
Committed http://trac.webkit.org/r235633
Alexey Proskuryakov
Comment 8 2018-09-04 14:16:14 PDT
And r235634 for a "print" forgotten in run-leaks.
Joseph Pecoraro
Comment 9 2018-09-10 10:23:06 PDT
Comment on attachment 348647 [details] proposed patch Nice!
Note You need to log in before you can comment on or make changes to this bug.