Summary: | Add completion handlers to TestRunner functions setStatisticsLastSeen(), setStatisticsPrevalentResource(), setStatisticsVeryPrevalentResource(), setStatisticsHasHadUserInteraction(), and setStatisticsHasHadNonRecentUserInteraction() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Wilander <wilander> | ||||||
Component: | Tools / Tests | Assignee: | John Wilander <wilander> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, lforschler, ryanhaddad, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
John Wilander
2018-07-16 13:09:10 PDT
Retitling to reflect the changes I'm making to address the flakiness. Created attachment 345132 [details]
Patch
Comment on attachment 345132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345132&action=review r=me with nits. > Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:80 > + store->setLastSeen(WebCore::URL(WebCore::URL(), WebKit::toImpl(host)->string()), Seconds { seconds }, [context, completionHandler]() { () not needed. > Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:94 > + store->setPrevalentResource(WebCore::URL(WebCore::URL(), WebKit::toImpl(host)->string()), [context, completionHandler]() { () not needed. > Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:112 > + store->setVeryPrevalentResource(WebCore::URL(WebCore::URL(), WebKit::toImpl(host)->string()), [context, completionHandler]() { () not needed. > Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:116 > + store->clearPrevalentResource(WebCore::URL(WebCore::URL(), WebKit::toImpl(host)->string()), [context, completionHandler]() { () not needed. > Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:182 > + store->logUserInteraction(WebCore::URL(WebCore::URL(), WebKit::toImpl(host)->string()), [context, completionHandler]() { () not needed. > Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:186 > + store->clearUserInteraction(WebCore::URL(WebCore::URL(), WebKit::toImpl(host)->string()), [context, completionHandler]() { () not needed. > Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:199 > + store->logNonRecentUserInteraction(WebCore::URL(WebCore::URL(), WebKit::toImpl(host)->string()), [context, completionHandler]() { () not needed. > Tools/WebKitTestRunner/TestController.cpp:2720 > + Bad extra line. Created attachment 345159 [details]
Patch for landing
Thanks, Chris! Comment on attachment 345159 [details] Patch for landing Clearing flags on attachment: 345159 Committed r233888: <https://trac.webkit.org/changeset/233888> All reviewed patches have been landed. Closing bug. |