Summary: | postMessage should dispatch an event to Window, not Document | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, collinj, jwalden+bwo, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
URL: | http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2008-April/014570.html | ||||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2008-04-27 07:30:03 PDT
This can probably happen either before or after Bug 18725, but the patches are likely to touch some of the same lines of code. Created attachment 20997 [details]
Work in progress
Here is a work-in-progress patch. I really need to get a Mac so I can run the LayoutTests.
Created attachment 21010 [details]
Patch
I ran the tests and they pass. I added a comment to cross-domain-message-event-dispatch.html explaining why postMessage events are faster than setTimeout handlers.
Comment on attachment 21010 [details]
Patch
I realize this is just being moved, but the & is in the wrong place.
+void EventTargetNode::dispatchWindowEvent(const AtomicString &eventType, bool canBubbleArg, bool cancelableArg)
r=me. (Anders gave his approval too!)
Fix landed in r33006? Does this mean we are up to date with the postMessage spec? (In reply to comment #5) > Fix landed in r33006? Can you not remember? Here's a hint: <http://trac.webkit.org/changeset/33006> |