Bug 187703

Summary: Web Inspector: Fix execution highlighting after r233820
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Matt Baker
Reported 2018-07-16 10:41:28 PDT
Summary: Fix execution highlighting after r233820. In https://webkit.org/b/187613, the arguments to TextEditor.prototype.getTextInRange were changed to SourceCodePosition instead of CodeMirror.Pos. A call site in SourceCodeTextEditor was missed.
Attachments
Patch (3.74 KB, patch)
2018-07-16 10:43 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-07-16 10:42:07 PDT
<rdar://problem/42246167>
Matt Baker
Comment 2 2018-07-16 10:43:53 PDT
Created attachment 345099 [details] Patch
Joseph Pecoraro
Comment 3 2018-07-16 12:39:58 PDT
Comment on attachment 345099 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2018-07-16 13:06:59 PDT
Comment on attachment 345099 [details] Patch Clearing flags on attachment: 345099 Committed r233861: <https://trac.webkit.org/changeset/233861>
WebKit Commit Bot
Comment 5 2018-07-16 13:07:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.