Bug 187694

Summary: [GLIB] Add jsc_context_check_syntax() to GLib API
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ysuzuki: review-
Updated patch ysuzuki: review+

Carlos Garcia Campos
Reported 2018-07-16 05:38:03 PDT
A wrapper for JSCheckScriptSyntax to be able to check for syntax errors without actually evaluating the code.
Attachments
Patch (8.23 KB, patch)
2018-07-16 05:39 PDT, Carlos Garcia Campos 		ysuzuki: review-
DetailsFormatted DiffDiff
Updated patch (13.34 KB, patch)
2018-07-18 05:40 PDT, Carlos Garcia Campos 		ysuzuki: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-07-16 05:39:38 PDT
Created attachment 345090 [details] Patch
Yusuke Suzuki
Comment 2 2018-07-16 07:00:11 PDT
Comment on attachment 345090 [details] Patch Looks good. But, I think this API does not consider about ES6 modules. Module and Script have different syntax elements. For example, `import` declaration is not allowed under Script mode. We should take an argument indicating the mode.
Carlos Garcia Campos
Comment 3 2018-07-18 05:40:26 PDT
Created attachment 345238 [details] Updated patch
Yusuke Suzuki
Comment 4 2018-07-18 05:48:24 PDT
Comment on attachment 345238 [details] Updated patch r=me
Carlos Garcia Campos
Comment 5 2018-07-18 05:54:56 PDT
Committed r233911: <https://trac.webkit.org/changeset/233911>
Radar WebKit Bug Importer
Comment 6 2018-07-18 05:55:21 PDT
<rdar://problem/42331406>
Note You need to log in before you can comment on or make changes to this bug.