Bug 187663

Summary: REGRESSION (r231676): watchOS WebKit usually doesn't load in the background
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, cdumez, commit-queue, ews-watchlist, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+, commit-queue: commit-queue-

Description Tim Horton 2018-07-13 14:46:44 PDT
REGRESSION (r231676): watchOS WebKit usually doesn't load in the background
Comment 1 Tim Horton 2018-07-13 14:47:32 PDT
Created attachment 344985 [details]
Patch
Comment 2 EWS Watchlist 2018-07-13 14:49:22 PDT
Attachment 344985 [details] did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2018-07-13 14:54:07 PDT
Comment on attachment 344985 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-07-13 15:11:32 PDT
Comment on attachment 344985 [details]
Patch

Rejecting attachment 344985 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 344985, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/8529658
Comment 5 Chris Dumez 2018-07-13 15:14:15 PDT
Comment on attachment 344985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344985&action=review

> Source/WebKit/ChangeLog:4
> +        Need the bug URL (OOPS!).

Looks wrong :D
Comment 6 Tim Horton 2018-07-13 15:29:22 PDT
(In reply to Chris Dumez from comment #5)
> Comment on attachment 344985 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344985&action=review
> 
> > Source/WebKit/ChangeLog:4
> > +        Need the bug URL (OOPS!).
> 
> Looks wrong :D

Yeah, dumb webkit-patch -g
Comment 7 Tim Horton 2018-07-13 15:34:07 PDT
https://trac.webkit.org/changeset/233818/webkit
Comment 8 Tim Horton 2018-07-13 15:42:34 PDT
<rdar://problem/42181185>