Bug 187645 – Release test-262 tests failed

• Component: Tools / Tests
• Status: RESOLVED WORKSFORME

[Dawei Fenton (:realdawei)]

Created attachment 344944 [details]
stdio

Seeing a test-262 failure after revision: https://trac.webkit.org/changeset/233795/webkit

https://build.webkit.org/builders/Apple%20Sierra%20Release%20Test262%20%28Tests%29/builds/3408/steps/test262-test/logs/stdio

FAIL test/annexB/built-ins/Function/createdynfn-html-open-comment-params.js (strict mode)
Exception: SyntaxError: Unexpected token '}'. Expected a parameter pattern or a ')' in parameter list.
at /Volumes/Data/slave/sierra-release-tests-test262/build/JSTests/test262/test/annexB/built-ins/Function/createdynfn-html-open-comment-params.js:3
Function@[native code]
global code@/Volumes/Data/slave/sierra-release-tests-test262/build/JSTests/test262/test/annexB/built-ins/Function/createdynfn-html-open-comment-params.js:22:9
....
Exception: SyntaxError: Unexpected token '}'. Expected a parameter pattern or a ')' in parameter list.
at /Volumes/Data/slave/sierra-release-tests-test262/build/JSTests/test262/test/annexB/built-ins/Function/createdynfn-html-open-comment-params.js:3
Function@[native code]
global code@/Volumes/Data/slave/sierra-release-tests-test262/build/JSTests/test262/test/annexB/built-ins/Function/createdynfn-html-open-comment-params.js:21:9
....
Exception: SyntaxError: Unexpected token '--'. Expected a parameter pattern or a ')' in parameter list.
at /Volumes/Data/slave/sierra-release-tests-test262/build/JSTests/test262/test/annexB/built-ins/Function/createdynfn-html-close-comment-params.js:1
Function@[native code]
global code@/Volumes/Data/slave/sierra-release-tests-test262/build/JSTests/test262/test/annexB/built-ins/Function/createdynfn-html-close-comment-params.js:21:9

[Ryan Haddad]

I think that test is expected to fail, as subsequent runs have passed even though that same error appears.

[Ryan Haddad]

(In reply to David Fenton (:realdawei) from comment #0)
> https://build.webkit.org/builders/
> Apple%20Sierra%20Release%20Test262%20%28Tests%29/builds/3408/steps/test262-
> test/logs/stdio

This run doesn't show a summary at the end, and I see 'process killed by signal 13', so it looks like something prevented the script from completing.

[Dawei Fenton (:realdawei)]

(In reply to Ryan Haddad from comment #2)
> (In reply to David Fenton (:realdawei) from comment #0)
> > https://build.webkit.org/builders/
> > Apple%20Sierra%20Release%20Test262%20%28Tests%29/builds/3408/steps/test262-
> > test/logs/stdio
> 
> This run doesn't show a summary at the end, and I see 'process killed by
> signal 13', so it looks like something prevented the script from completing.

True, I see that's it run successfully twice since, so closing the bug.

[Ryan Haddad]

Looking at this queues history, it looks like the tests have failed this way 4 times out of the last 200 runs.

I'm not sure under what conditions this reproduces. I haven't tried locally.

CC'ing Leo and Valerie for visibility.

[Leo Balter]

heh, that's probably a bug in JSC. As far as I checked here, JSC should definitely pass for this test case, but:

```
>>> a = Function("<!--", "");
Exception: SyntaxError: Unexpected token '}'. Expected a parameter pattern or a ')' in parameter list.
```

If it passes, the following is expected:

```
a.toString();
/*--
"function anonymous(<!--
) {

}"
--*/
```

The same bug happens when we try it with a regular inline comment:

```
Function('//', '')
```

The inline comment should not affect the function body, but only consequent parameters.

I checked that other major engines are working as expected.

[Alexey Proskuryakov]

Should this be re-opened? Or perhaps it's better to have a new bug that clearly describes the issue? This one has a title that isn't super descriptive.