Bug 187634

Summary: Signal.cpp's activeThreads() should only create its ThreadGroup once.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Mark Lam
Reported 2018-07-12 22:34:07 PDT
registerThreadForMachExceptionHandling() is relying on the activeThreads() ThreadGroup being a singleton. <rdar://problem/40662311>
Attachments
proposed patch. (1.62 KB, patch)
2018-07-12 22:40 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-07-12 22:40:12 PDT
Created attachment 344926 [details] proposed patch.
Yusuke Suzuki
Comment 2 2018-07-12 22:50:31 PDT
Comment on attachment 344926 [details] proposed patch. r=me
Mark Lam
Comment 3 2018-07-12 23:37:11 PDT
Comment on attachment 344926 [details] proposed patch. Thanks for the review. Landing now.
WebKit Commit Bot
Comment 4 2018-07-13 00:04:17 PDT
Comment on attachment 344926 [details] proposed patch. Clearing flags on attachment: 344926 Committed r233795: <https://trac.webkit.org/changeset/233795>
WebKit Commit Bot
Comment 5 2018-07-13 00:04:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.