Bug 187600

Summary: [GStreamer] Add GstBufferMapped abstraction
Product: WebKit Reporter: Charlie Turner <cturner>
Component: WebKitGTKAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue, ews-watchlist
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Charlie Turner
Reported 2018-07-12 07:12:19 PDT
[GStreamer] Add GstBufferMapped abstraction
Attachments
Patch (17.14 KB, patch)
2018-07-12 07:16 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch (17.11 KB, patch)
2018-07-12 07:22 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Charlie Turner
Comment 1 2018-07-12 07:16:02 PDT
Created attachment 344841 [details] Patch
EWS Watchlist
Comment 2 2018-07-12 07:17:17 PDT
Attachment 344841 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Charlie Turner
Comment 3 2018-07-12 07:22:22 PDT
Created attachment 344842 [details] Patch
Xabier Rodríguez Calvar
Comment 4 2018-07-13 00:43:31 PDT
Comment on attachment 344842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344842&action=review > Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:303 > + gst_byte_reader_free(reader); Interesting catch! We should do this (not necessarily now) a GUniquePtr.
WebKit Commit Bot
Comment 5 2018-07-13 01:10:58 PDT
Comment on attachment 344842 [details] Patch Clearing flags on attachment: 344842 Committed r233796: <https://trac.webkit.org/changeset/233796>
WebKit Commit Bot
Comment 6 2018-07-13 01:11:00 PDT
All reviewed patches have been landed. Closing bug.
Philippe Normand
Comment 7 2018-08-16 01:30:42 PDT
*** Bug 187586 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.