Bug 187591 – [GTK] imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality.html is flaky

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Miguel Gomez]

imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality.html [ Failure Crash ]

The test moves between crashing and failing with text constantly. When it fails with text, this is the diff:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality-actual.txt
@@ -1,4 +1,4 @@
 
-PASS Test HTMLVideoElement.getVideoPlaybackQuality() with MediaSource API 
-PASS Test the totalFrameDelay attribute of HTMLVideoElement.getVideoPlaybackQuality() with MediaSource API 
+FAIL Test HTMLVideoElement.getVideoPlaybackQuality() with MediaSource API assert_unreached: Unexpected event 'error' Reached unreachable code
+FAIL Test the totalFrameDelay attribute of HTMLVideoElement.getVideoPlaybackQuality() with MediaSource API assert_unreached: Unexpected event 'error' Reached unreachable code
 

The first crash happened in r233638. Before that it was mostly passing with text failure every now and then. I cannot be sure that r233638 is the cause of the crash, but adding the author just in case. The crash log can be seen here


https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r233765%20(7376)/imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality-crash-log.txt

[Thibault Saunier]

Seem related to the implementation of MediaStream, looking into it.

[Thibault Saunier]

(In reply to Thibault Saunier from comment #1)
> Seem related to the implementation of MediaStream, looking into it.

Sorry I misread it is about MediaSource (a.k.a MSE) and is not related   at all with MediaStream. Also I do not see any way it is related to r233638 as that one is about flatpak which is not use on the build bots yet.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 347786 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 347786 [details]
Patch

Clearing flags on attachment: 347786

Committed r235168: <https://trac.webkit.org/changeset/235168>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.