Bug 187577 – REGRESSION(r233742): Binary incompatible change with respect to Service Worker registration map (Requested by dydz on #webkit).

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Commit Bot]

https://trac.webkit.org/changeset/233742 broke the build:
Binary incompatible change with respect to Service Worker registration map (Requested by dydz on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

[WebKit Commit Bot]

Created attachment 344817 [details]
ROLLOUT of r233742

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[WebKit Commit Bot]

Comment on attachment 344817 [details]
ROLLOUT of r233742

Clearing flags on attachment: 344817

Committed r233755: <https://trac.webkit.org/changeset/233755>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Daniel Bates]

I hit <https://trac.webkit.org/browser/trunk/Source/WebCore/platform/URL.h?rev=233751#L298> when loading http://forums.swift.org.

[Radar WebKit Bug Importer]

<rdar://problem/42102125>

[Radar WebKit Bug Importer]

<rdar://problem/42102131>

[Daniel Bates]

Created attachment 344818 [details]
Backtrace

Backtrace. Here is the state of all auto variables in frame 1:

decoder WTF::Persistence::Decoder & 0x000070000d278068
    m_buffer    const uint8_t * "\x01"  0x000000010ff00000
    m_bufferPosition    const uint8_t * ""  0x000000010ff000a9
    m_bufferEnd const uint8_t * ""  0x000000010ff2a13e
    m_sha1  WTF::SHA1
cannotBeABaseURL    bool    true
url WebCore::URL    { https://www.gstatic.com/_/boq/_/js/k=boq.PlusappPushNotificationsServiceWorker.en.n5zhEZtca6Q.O/m=base/rt=j/d=1/rs=AGLTcCMXVNBVxGhgmHHtaimge4CNbOBDjQ }   
    m_string    WTF::String { length = 149, contents = 'https://www.gstatic.com/_/boq/_/js/k=boq.PlusappPushNotificationsServiceWorker.en.n5zhEZtca6Q.O/m=base/rt=j/d=1/rs=AGLTcCMXVNBVxGhgmHHtaimge4CNbOBDjQ' }    
    m_isValid   unsigned int    1
    m_protocolIsInHTTPFamily    unsigned int    1
    m_cannotBeABaseURL  unsigned int    1
    m_portLength    unsigned int    0
    m_schemeEnd unsigned int    0
    m_userStart unsigned int    0
    m_userEnd   unsigned int    0
    m_passwordEnd   unsigned int    0
    m_hostEnd   unsigned int    0
    m_pathAfterLastSlash    unsigned int    0
    m_pathEnd   unsigned int    0
    m_queryEnd  unsigned int    0
    schemeEnd   unsigned int    134217728
std::nullopt    const std::nullopt_t