Bug 187559
| Summary: | REGRESSION (r233714): JSC test stress/keep-checks-when-converting-to-lazy-js-constant-in-strength-reduction.js is timing out | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | ap, fpizlo, realdawei, saam, tsavell, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=187540 | ||
Ryan Haddad
JSC test stress/keep-checks-when-converting-to-lazy-js-constant-in-strength-reduction.js is timing out on Release and Debug bots:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20JSC%20%28Tests%29/builds/4762
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/1251
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryan Haddad
This was the only JSC change in that range:
"Change the reoptimization backoff base to 1.3 from 2"
https://trac.webkit.org/changeset/233714/webkit
Filip Pizlo
(In reply to Ryan Haddad from comment #1)
> This was the only JSC change in that range:
>
> "Change the reoptimization backoff base to 1.3 from 2"
> https://trac.webkit.org/changeset/233714/webkit
We should skip the test then.
Just add:
"//@ skip"
to the top of the .js file.
Ryan Haddad
Skipped in https://trac.webkit.org/r233743
Radar WebKit Bug Importer
<rdar://problem/42088527>
Alexey Proskuryakov
Why is this is marked RESOLVED, don't we want to make the test work again? If not, it should be deleted, not skipped. But it seems like a real test for a real important bug.
Alexey Proskuryakov
Re-opening.