Summary: | [iOS] WKWebView should match UITextView behavior when editing text with an RTL keyboard | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||||||||
Component: | HTML Editing | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bdakin, commit-queue, darin, ews-watchlist, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | Other | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
mitz
2018-07-11 09:42:49 PDT
*** Bug 192393 has been marked as a duplicate of this bug. *** Created attachment 356716 [details]
WIP
Comment on attachment 356716 [details] WIP Attachment 356716 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10289338 New failing tests: editing/input/ios/rtl-keyboard-input-on-focus.html Created attachment 356721 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 356736 [details]
First pass
Comment on attachment 356736 [details] First pass View in context: https://bugs.webkit.org/attachment.cgi?id=356736&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:1875 > + if (isValid()) This is a surprising and bizarre pattern! Would much prefer if these were all early returns, despite being more lines. > Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:911 > + m_waitingForPostLayoutEditorStateUpdateAfterFocusingElement = false; Do we get here if the process dies? (otherwise, you might need to reset this there too? > Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:176 > + > + if (options.editable) > + m_mainWebView->setEditable(true); How did we not have this before Created attachment 356738 [details]
Patch for EWS
Comment on attachment 356736 [details] First pass View in context: https://bugs.webkit.org/attachment.cgi?id=356736&action=review >> Source/WebKit/UIProcess/WebPageProxy.cpp:1875 >> + if (isValid()) > > This is a surprising and bizarre pattern! Would much prefer if these were all early returns, despite being more lines. Ok! I'll change these to early returns. >> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:911 >> + m_waitingForPostLayoutEditorStateUpdateAfterFocusingElement = false; > > Do we get here if the process dies? (otherwise, you might need to reset this there too? Good catch β yes, this flag (as well as m_deferredNodeAssistanceArguments) should both be reset! >> Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:176 >> + m_mainWebView->setEditable(true); > > How did we not have this before π€·π»ββοΈ Comment on attachment 356738 [details] Patch for EWS View in context: https://bugs.webkit.org/attachment.cgi?id=356738&action=review > Source/WebKit/UIProcess/WebPageProxy.h:87 > +#include <WebCore/WritingDirection.h> Should be able to use forward declaration instead of include in this case. > Source/WebKit/WebProcess/WebPage/WebPage.h:73 > +#include <WebCore/WritingDirection.h> Ditto. (In reply to Darin Adler from comment #10) > Comment on attachment 356738 [details] > Patch for EWS > > View in context: > https://bugs.webkit.org/attachment.cgi?id=356738&action=review > > > Source/WebKit/UIProcess/WebPageProxy.h:87 > > +#include <WebCore/WritingDirection.h> > > Should be able to use forward declaration instead of include in this case. > > > Source/WebKit/WebProcess/WebPage/WebPage.h:73 > > +#include <WebCore/WritingDirection.h> > > Ditto. π will make these forward declarations before landing. Created attachment 356741 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 356741 [details]: workers/bomb.html bug 192050 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 356741 [details] Patch for landing Clearing flags on attachment: 356741 Committed r238939: <https://trac.webkit.org/changeset/238939> All reviewed patches have been landed. Closing bug. |