Bug 187467

Summary: [JSC] Make some data members of UnlinkedCodeBlock private
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2018-07-09 06:33:02 PDT
[JSC] Make some data members of UnlinkedCodeBlock private
Attachments
Patch (6.78 KB, patch)
2018-07-09 06:34 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-07-09 06:34:05 PDT
Created attachment 344579 [details] Patch
EWS Watchlist
Comment 2 2018-07-09 06:36:16 PDT
Attachment 344579 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:374: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:375: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2018-07-09 09:59:11 PDT
Comment on attachment 344579 [details] Patch r=me
Yusuke Suzuki
Comment 4 2018-07-09 10:09:48 PDT
Committed r233645: <https://trac.webkit.org/changeset/233645>
Radar WebKit Bug Importer
Comment 5 2018-07-09 10:10:30 PDT
<rdar://problem/41977825>
Note You need to log in before you can comment on or make changes to this bug.