Summary: | Flaky crash under WebCore::AXObjectCache::stopCachingComputedObjectAttributes() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dawei Fenton (:realdawei) <realdawei> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, ap, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, lforschler, n_wang, ryanhaddad, samuel_white, sroberts, tsavell, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Dawei Fenton (:realdawei)
2018-07-06 09:30:48 PDT
Test recently started showing up on bots as a crash in Mac Release as well. Probable cause: Local testing found that running accessibility/mac/attachment-element-replacement-character.html by itself produces no failures. However, testing accessibility/Mac/async-increment-decrement-action.html by itself will cause a crash roughly 5 times out of 500 iterations. Also when I run accessibility/Mac/async-increment-decrement-action.html followed by accessibility/mac/attachment-element-replacement-character.html , the async-increment test will crash, and blame the attach-element test. Local crashes match crash logs seen here, as well as on the bots. I tested with newest revisions, it also crashes with https://trac.webkit.org/changeset/230782/webkit when the accessibility/Mac/async-increment-decrement-action.html test was created Also crashes with https://trac.webkit.org/changeset/230855/webkit when the test was modified. Reproduced with : run-webkit-tests accessibility/Mac/async-increment-decrement-action.html accessibility/Mac/attachment-element-replacement-character.html --iterations 15 --debug - causes on average 4 in 15 crashes rwt --root t230781 accessibility/Mac/async-increment-decrement-action.html accessibility/Mac/attachment-element-replacement-character.html --iterations 5 - causes on average 2 in 5 crashes run-webkit-tests accessibility/mac/async-increment-decrement-action.html --iterations 500 -f - causes on average 7 in 500 crashes Skipping test locally will cause crashes to stop. Skipping test in https://trac.webkit.org/changeset/243710/webkit while waiting for a fix. Had a type in original expectation change. Redid in https://trac.webkit.org/changeset/244045/webkit Created attachment 368181 [details]
Patch
Comment on attachment 368181 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=368181&action=review > Source/WebCore/ChangeLog:7 > + CHeck for null return value of AccessibilityObject::axObjectCache. CHeck -> Check Created attachment 368185 [details]
Patch
(In reply to chris fleizach from comment #6) > Comment on attachment 368181 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=368181&action=review > > > Source/WebCore/ChangeLog:7 > > + CHeck for null return value of AccessibilityObject::axObjectCache. > > CHeck -> Check Fixed, and fixed grammar. Comment on attachment 368185 [details] Patch Clearing flags on attachment: 368185 Committed r244631: <https://trac.webkit.org/changeset/244631> All reviewed patches have been landed. Closing bug. |