Bug 187379 – Add support for fetching and remove type _WKWebsiteDataTypeHSTSCache

• Component: WebKit API
• Status: RESOLVED FIXED

[Sihui Liu]

Safari needs to show whether a host has HSTS cache and allow user to delete.

[Sihui Liu]

<rdar://22331772>

[Radar WebKit Bug Importer]

<rdar://problem/41879559>

[Sihui Liu]

Created attachment 344403 [details]
Patch

[EWS Watchlist]

Comment on attachment 344403 [details]
Patch

Attachment 344403 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8453501

New failing tests:
media/media-fullscreen-return-to-inline.html

[EWS Watchlist]

Created attachment 344405 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Sihui Liu]

Created attachment 344673 [details]
Patch

[Brent Fulgham]

Comment on attachment 344673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344673&action=review

I think this looks very close, but I believe your change to WebsiteDataRecord::displayNameForCookieHostName will break some ITP functionality. r- to revise that section, but otherwise I think this looks good.

> Source/WebCore/PAL/ChangeLog:3
> +        Add support for fetching and remove type  _WKWebsiteDataTypeHSTSCache

You have an extra space between 'type' and '_WKWebsite..'

> Source/WebKit/ChangeLog:3
> +        Add support for fetching and remove type  _WKWebsiteDataTypeHSTSCache

Ditto.

> Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:155
> +    HashSet<String>* hostnames = (HashSet<String>*)context;

You should use the proper C++ casting here (probably a reinterpret_cast).

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp:51
> +    return displayNameForHostName(hostName);

I don't think this change is correct, since you are losing the special handling of localhost and removal of the leading period.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1008
> +

Please remove this whitespace change.

[Sihui Liu]

Comment on attachment 344673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344673&action=review

>> Source/WebCore/PAL/ChangeLog:3
>> +        Add support for fetching and remove type  _WKWebsiteDataTypeHSTSCache
> 
> You have an extra space between 'type' and '_WKWebsite..'

Done.

>> Source/WebKit/ChangeLog:3
>> +        Add support for fetching and remove type  _WKWebsiteDataTypeHSTSCache
> 
> Ditto.

Done.

>> Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:155
>> +    HashSet<String>* hostnames = (HashSet<String>*)context;
> 
> You should use the proper C++ casting here (probably a reinterpret_cast).

Yes! Will fix.

>> Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp:51
>> +    return displayNameForHostName(hostName);
> 
> I don't think this change is correct, since you are losing the special handling of localhost and removal of the leading period.

displayNameForHostName calls WebCore::topPrivatelyControlledDomain, and in WebCore::topPrivatelyControlledDomain we will check leading period and "localhost", so we could remove the check here.

>> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1008
>> +
> 
> Please remove this whitespace change.

Done.

[Sihui Liu]

Created attachment 345829 [details]
Patch

[Geoffrey Garen]

Comment on attachment 345829 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345829&action=review

r=me

> Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:155
> +    HashSet<String>* hostnames = reinterpret_cast<HashSet<String>*>(context);

This can be static_cast because void* can static_cast to any pointer.

[Sihui Liu]

Created attachment 346110 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 346110 [details]
Patch for landing

Clearing flags on attachment: 346110

Committed r234396: <https://trac.webkit.org/changeset/234396>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.