Summary: | Regression(r232886): WebsiteDataStore objects may get destroyed on a background thread | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson, commit-queue, ggaren, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 186682 | ||||||
Attachments: |
|
Description
Chris Dumez
2018-07-05 12:37:21 PDT
Created attachment 344353 [details]
Patch
Comment on attachment 344353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344353&action=review > Source/WebKit/ChangeLog:17 > + store member on the main thread. Note that we could also have WebsiteDataStore subclass Let me know if you think I should do this instead. Comment on attachment 344353 [details]
Patch
r=me
I think this is the best design for now because we generally require our API objects to be used only on the main thread.
If we ever want to reconsider that requirement, we can reconsider this change too.
Comment on attachment 344353 [details] Patch Clearing flags on attachment: 344353 Committed r233538: <https://trac.webkit.org/changeset/233538> All reviewed patches have been landed. Closing bug. |