| Summary: | REGRESSION (r230843): Flash doesn't work; Produces blue box on page | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> |
| Component: | Plug-ins | Assignee: | youenn fablet <youennf> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | achristensen, cdumez, commit-queue, ews-watchlist, ggaren, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=187550 | ||
| Attachments: | |||
|
Description
youenn fablet
2018-07-05 09:23:47 PDT
Created attachment 344341 [details]
Patch
Comment on attachment 344341 [details] Patch Attachment 344341 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8447110 New failing tests: http/tests/plugins/plugin-allow-then-reload.html Created attachment 344349 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 344341 [details] Patch Attachment 344341 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8447149 New failing tests: http/tests/plugins/plugin-allow-then-reload.html Created attachment 344350 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 344341 [details] Patch Attachment 344341 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8447146 New failing tests: http/tests/plugins/plugin-allow-then-reload.html Created attachment 344352 [details]
Archive of layout-test-results from ews116 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 344364 [details]
Patch
Comment on attachment 344364 [details] Patch Attachment 344364 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8449305 New failing tests: http/tests/plugins/plugin-allow-then-reload.html Created attachment 344370 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 344364 [details] Patch Attachment 344364 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8449482 New failing tests: animations/needs-layout.html Created attachment 344376 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Created attachment 344386 [details]
Patch
Comment on attachment 344386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344386&action=review > Source/WebCore/testing/Internals.cpp:4643 > +#if PLATFORM(MAC) Why does this code need to be macOS specific? > LayoutTests/http/tests/plugins/plugin-allow-then-reload.html:18 > + if (window.testRunner) > + testRunner.setBlockAllPlugins(true); I don't think it makes sense to guard this behind if (window.testRunner) since the test doesn't do anything useful without it, and you're exiting early above. > LayoutTests/http/tests/plugins/plugin-allow-then-reload.html:37 > + console.log("number of plugins decreased after blocking: " + (test1 ? "PASS" : "FAIL")); > + console.log("number of plugins increased after allowing: " + (test2 ? "PASS" : "FAIL")); Can't we just dump all of this into body instead? Created attachment 344399 [details]
Patch for landing
Thanks for the review, patch updated accordingly. Comment on attachment 344399 [details] Patch for landing Attachment 344399 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8452659 New failing tests: http/tests/security/video-poster-cross-origin-crash2.html Created attachment 344402 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 344399 [details] Patch for landing Clearing flags on attachment: 344399 Committed r233563: <https://trac.webkit.org/changeset/233563> All reviewed patches have been landed. Closing bug. |