Bug 187317

Summary: Rename HTMLTreeBuilder::didCreateCustomOrCallbackElement
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: CSSAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, ews-watchlist, gyuyoung.kim, rniwa, rwlbuis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 154908    
Bug Blocks: 183586    
Attachments:
Description Flags
Patch none

Frédéric Wang (:fredw)
Reported 2018-07-04 01:43:27 PDT
In bug r197463, a new function HTMLTreeBuilder::didCreateCustomOrCallbackElement was introduced. It seems that what is meant is a really *Fallback* element, so we should rename the function.
Attachments
Patch (3.62 KB, patch)
2018-07-04 02:01 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2018-07-04 02:01:01 PDT
Created attachment 344269 [details] Patch
WebKit Commit Bot
Comment 2 2018-07-06 00:48:57 PDT
Comment on attachment 344269 [details] Patch Clearing flags on attachment: 344269 Committed r233572: <https://trac.webkit.org/changeset/233572>
WebKit Commit Bot
Comment 3 2018-07-06 00:48:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-07-06 00:49:24 PDT
<rdar://problem/41882574>
Note You need to log in before you can comment on or make changes to this bug.