Bug 187287

Summary: Add a release assert to diagnose infinite recursions in removeAllEventListeners()
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: UI EventsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, ddkilzer, esprehn+autocc, ews-watchlist, kangil.han, keith_miller, mark.lam, msaboff, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds the assertion
none
Adds the assertion keith_miller: review+

Ryosuke Niwa
Reported 2018-07-03 00:55:31 PDT
Somehow we're encountering infinite recursions inside removeAllEventListeners(): e.g. Thread 0 Crashed ↩:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x00007fff53718587 WebCore::EventTarget::removeAllEventListeners() + 7 1 com.apple.WebCore 0x00007fff5371858a WebCore::EventTarget::removeAllEventListeners() + 10 2 com.apple.WebCore 0x00007fff5371858a WebCore::EventTarget::removeAllEventListeners() + 10 3 com.apple.WebCore 0x00007fff5371858a WebCore::EventTarget::removeAllEventListeners() + 10 4 com.apple.WebCore 0x00007fff5371858a WebCore::EventTarget::removeAllEventListeners() + 10 ... 511 com.apple.WebCore 0x00007fff5371858a WebCore::EventTarget::removeAllEventListeners() + 10 ... Add a release assertion to reveal the earlier stack trace in order to diagnose this crash.
Attachments
Adds the assertion (5.61 KB, patch)
2018-07-03 17:26 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Adds the assertion (2.62 KB, patch)
2018-07-03 17:27 PDT, Ryosuke Niwa 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-07-03 17:26:38 PDT
Created attachment 344245 [details] Adds the assertion
Ryosuke Niwa
Comment 2 2018-07-03 17:27:24 PDT
Created attachment 344246 [details] Adds the assertion
Radar WebKit Bug Importer
Comment 3 2018-07-03 17:28:03 PDT
<rdar://problem/41799974>
Keith Miller
Comment 4 2018-07-03 19:23:39 PDT
Comment on attachment 344246 [details] Adds the assertion r=me.
Ryosuke Niwa
Comment 5 2018-07-03 19:33:09 PDT
Committed r233493: <https://trac.webkit.org/changeset/233493>
Note You need to log in before you can comment on or make changes to this bug.