Summary: | Crash in WebKit::CacheStorage::Cache::toRecordInformation when running http/tests/cache-storage/cache-persistency.https.html | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||||
Component: | Page Loading | Assignee: | youenn fablet <youennf> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, beidson, cdumez, cgarcia, commit-queue, ews-watchlist, fred.wang, mcatanzaro, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=186536 https://bugs.webkit.org/show_bug.cgi?id=182928 |
||||||||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2018-07-02 00:11:13 PDT
Same crash sometimes happens with http/tests/cache-storage/cache-representation.https.html https://trac.webkit.org/changeset/233418/ Created attachment 344136 [details]
Patch
Comment on attachment 344136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344136&action=review > LayoutTests/TestExpectations:-390 > -webkit.org/b/187243 http/tests/cache-storage/cache-persistency.https.html [ Crash ] Can you also please remove the "Crash" for cache-representation.https.html? See comment 1 (I was not sure whether TestExpectations accept multiple bug references...) Created attachment 344155 [details]
Patch
Comment on attachment 344155 [details] Patch Attachment 344155 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8419260 New failing tests: http/tests/security/local-video-source-from-remote.html Created attachment 344160 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 344155 [details]
Patch
Error is unrelated
Comment on attachment 344155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344155&action=review LGTM. It would be great to take this ASAP since it is making execution of WK2 layout tests regularly fail e.g. https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r233451%20(7099)/results.html https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r233453%20(5961)/results.html > Source/WebKit/ChangeLog:3 > + Crash in WebKit::CacheStorage::Cache::toRecordInformation when running http/tests/cache-storage/cache-persistency.https.html nit: there is a double space after "Crash in" > LayoutTests/ChangeLog:3 > + Crash in WebKit::CacheStorage::Cache::toRecordInformation when running http/tests/cache-storage/cache-persistency.https.html Ditto. Comment on attachment 344155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344155&action=review > Source/WebKit/ChangeLog:7 > + Please explain the fix in the changelog. Created attachment 344199 [details]
Patch
Comment on attachment 344199 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344199&action=review > LayoutTests/TestExpectations:389 > webkit.org/b/187145 imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html [ Crash ] The conflict is probably due to https://trac.webkit.org/changeset/233458/webkit Created attachment 344244 [details]
Rebasing
Comment on attachment 344244 [details] Rebasing Clearing flags on attachment: 344244 Committed r233492: <https://trac.webkit.org/changeset/233492> All reviewed patches have been landed. Closing bug. |