Bug 187215

Summary: Generate event and event target interface types directly instead of via macros
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: UI EventsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dbates, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Cmake build fix attempt cdumez: review+

Ryosuke Niwa
Reported 2018-06-29 22:22:36 PDT
Right now, make_event_factory.pl generates a bunch of macros in order to define EventInterface and EventTargetInterface as well as toJS and toJSNewlyCreated. Generate the final code directly to make debugging easier.
Attachments
Cleanup (19.46 KB, patch)
2018-06-29 22:45 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Cmake build fix attempt (21.52 KB, patch)
2018-06-29 23:58 PDT, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-06-29 22:45:21 PDT
Created attachment 343998 [details] Cleanup
Ryosuke Niwa
Comment 2 2018-06-29 23:58:45 PDT
Created attachment 344004 [details] Cmake build fix attempt
Chris Dumez
Comment 3 2018-07-02 15:43:19 PDT
Comment on attachment 344004 [details] Cmake build fix attempt View in context: https://bugs.webkit.org/attachment.cgi?id=344004&action=review > Source/WebCore/ChangeLog:9 > + and EventTargetInterface enum values and toJS for EventTarget. Removed the code to generate EvnentFactory::create Typo: EvnentFactory
Ryosuke Niwa
Comment 4 2018-07-02 15:54:34 PDT
Committed r233443: <https://trac.webkit.org/changeset/233443>
Radar WebKit Bug Importer
Comment 5 2018-07-02 15:55:24 PDT
<rdar://problem/41745345>
Note You need to log in before you can comment on or make changes to this bug.