| Summary: | Add utility methods to WebResourceLoadStatisticsStore to hop back and forth between threads | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | beidson, bfulgham, commit-queue, ews-watchlist, ggaren, rniwa, wilander, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 187247 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2018-06-29 16:00:01 PDT
Created attachment 343962 [details]
Patch
Comment on attachment 343962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343962&action=review Looks much tidier! r=me. > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:86 > ASSERT(RunLoop::isMain()); We can get rid of this ASSERT here, can't we? > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:96 > ASSERT(RunLoop::isMain()); Ditto. > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:106 > ASSERT(RunLoop::isMain()); Ditto. Comment on attachment 343962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343962&action=review >> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:86 >> ASSERT(RunLoop::isMain()); > > We can get rid of this ASSERT here, can't we? It is documenting, I kind of like them. Comment on attachment 343962 [details] Patch Attachment 343962 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8388725 Number of test failures exceeded the failure limit. Created attachment 343971 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 343974 [details]
Patch
Comment on attachment 343974 [details] Patch Clearing flags on attachment: 343974 Committed r233381: <https://trac.webkit.org/changeset/233381> All reviewed patches have been landed. Closing bug. |