Bug 187200

Summary: Add utility methods to WebResourceLoadStatisticsStore to hop back and forth between threads
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, commit-queue, ews-watchlist, ggaren, rniwa, wilander, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 187247    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Patch none

Chris Dumez
Reported 2018-06-29 16:00:01 PDT
Add utility methods to WebResourceLoadStatisticsStore to hop back and forth between threads, in order the simplify the code a little bit.
Attachments
Patch (40.24 KB, patch)
2018-06-29 16:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (1.57 MB, application/zip)
2018-06-29 16:51 PDT, EWS Watchlist 		no flags
Details
Patch (40.26 KB, patch)
2018-06-29 16:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-06-29 16:02:18 PDT
Created attachment 343962 [details] Patch
Brent Fulgham
Comment 2 2018-06-29 16:30:59 PDT
Comment on attachment 343962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343962&action=review Looks much tidier! r=me. > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:86 > ASSERT(RunLoop::isMain()); We can get rid of this ASSERT here, can't we? > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:96 > ASSERT(RunLoop::isMain()); Ditto. > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:106 > ASSERT(RunLoop::isMain()); Ditto.
Chris Dumez
Comment 3 2018-06-29 16:40:07 PDT
Comment on attachment 343962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343962&action=review >> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:86 >> ASSERT(RunLoop::isMain()); > > We can get rid of this ASSERT here, can't we? It is documenting, I kind of like them.
EWS Watchlist
Comment 4 2018-06-29 16:51:55 PDT
Comment on attachment 343962 [details] Patch Attachment 343962 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8388725 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 5 2018-06-29 16:51:56 PDT
Created attachment 343971 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Chris Dumez
Comment 6 2018-06-29 16:54:20 PDT
Created attachment 343974 [details] Patch
WebKit Commit Bot
Comment 7 2018-06-29 17:35:36 PDT
Comment on attachment 343974 [details] Patch Clearing flags on attachment: 343974 Committed r233381: <https://trac.webkit.org/changeset/233381>
WebKit Commit Bot
Comment 8 2018-06-29 17:35:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-07-02 08:27:39 PDT
<rdar://problem/41723818>
Note You need to log in before you can comment on or make changes to this bug.