Bug 187181

Summary: Returning PiP'd video to fullscreen while playing leaves video muted.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch eric.carlson: review+

Jer Noble
Reported 2018-06-29 09:05:57 PDT
Returning PiP'd video to fullscreen while playing leaves video muted.
Attachments
Patch (4.28 KB, patch)
2018-06-29 09:13 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (7.36 KB, patch)
2018-06-29 09:21 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-06-29 09:06:16 PDT
<rdar://problem/41408335>
Jer Noble
Comment 2 2018-06-29 09:13:44 PDT
Created attachment 343915 [details] Patch
Jer Noble
Comment 3 2018-06-29 09:21:27 PDT
Created attachment 343918 [details] Patch
Eric Carlson
Comment 4 2018-06-29 09:23:41 PDT
Comment on attachment 343918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343918&action=review > LayoutTests/media/picture-in-picture-interruption.html:34 > + <div>This tests that video is in the correct media session state after enting a background interruption while pipped.</div> Nit: "enting"
Jer Noble
Comment 5 2018-06-29 10:15:47 PDT
Committed r233360: <https://trac.webkit.org/changeset/233360>
Ryan Haddad
Comment 6 2018-06-29 17:25:39 PDT
media/picture-in-picture-interruption.html is timing out on iOS Simulator bots: https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r233374%20(5903)/results.html
Ryan Haddad
Comment 7 2018-06-29 17:29:54 PDT
(In reply to Ryan Haddad from comment #6) > media/picture-in-picture-interruption.html is timing out on iOS Simulator > bots: > > https://build.webkit.org/results/ > Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r233374%20(5903)/ > results.html Oh, probably because of: runWithKeyDown(function(){ video.webkitSetPresentationMode('picture-in-picture'); });
Ryan Haddad
Comment 8 2018-06-29 17:44:26 PDT
Skipped test on iOS in https://trac.webkit.org/r233382.
Note You need to log in before you can comment on or make changes to this bug.