Bug 187154

Summary: Resource Load Statistics: Don't create a WebResourceLoadStatisticsStore for ephemeral sessions
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, ews-watchlist
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews204 for win-future
none
Patch for landing none

John Wilander
Reported 2018-06-28 13:49:05 PDT
We should not create new WebResourceLoadStatisticsStore objects for ephemeral sessions since it creates duplicate in-memory stores. If we want to support a read-only mode, we should construct a singleton WebResourceLoadStatisticsStore object and detach it from the session.
Attachments
Patch (14.88 KB, patch)
2018-06-28 14:02 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (14.98 KB, patch)
2018-06-28 15:32 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (14.98 KB, patch)
2018-06-28 15:34 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (15.55 KB, patch)
2018-06-28 15:50 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews204 for win-future (12.93 MB, application/zip)
2018-06-29 03:25 PDT, EWS Watchlist 		no flags
Details
Patch for landing (8.50 KB, patch)
2018-06-29 12:33 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
John Wilander
Comment 1 2018-06-28 13:49:23 PDT
<rdar://problem/41487250>
John Wilander
Comment 2 2018-06-28 14:02:22 PDT
Created attachment 343846 [details] Patch
John Wilander
Comment 3 2018-06-28 15:32:26 PDT
Created attachment 343862 [details] Patch
John Wilander
Comment 4 2018-06-28 15:34:50 PDT
Created attachment 343863 [details] Patch
John Wilander
Comment 5 2018-06-28 15:50:14 PDT
Created attachment 343865 [details] Patch
Chris Dumez
Comment 6 2018-06-28 18:47:21 PDT
Comment on attachment 343865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343865&action=review LGTM, just a suggestion. > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1478 > We should probably ASSERT(!m_sessionID.isEphemeral()) here.
EWS Watchlist
Comment 7 2018-06-29 03:25:41 PDT
Comment on attachment 343865 [details] Patch Attachment 343865 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8380231 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html
EWS Watchlist
Comment 8 2018-06-29 03:25:53 PDT
Created attachment 343902 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Brent Fulgham
Comment 9 2018-06-29 09:58:24 PDT
Comment on attachment 343865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343865&action=review r=me, but I'm afraid you'll need to rebase your patch (after Chris's change) before you can land. > Source/WebKit/ChangeLog:9 > + Most of the changes in this patch removes the boolean parameter for tracking "Most of the changes in this patch REMOVE the boolean parameter for tracking" >> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1478 >> > > We should probably ASSERT(!m_sessionID.isEphemeral()) here. Agreed!
John Wilander
Comment 10 2018-06-29 12:33:22 PDT
Created attachment 343931 [details] Patch for landing
WebKit Commit Bot
Comment 11 2018-06-29 13:11:46 PDT
Comment on attachment 343931 [details] Patch for landing Clearing flags on attachment: 343931 Committed r233367: <https://trac.webkit.org/changeset/233367>
WebKit Commit Bot
Comment 12 2018-06-29 13:11:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.