| Summary: | Resource Load Statistics: Don't create a WebResourceLoadStatisticsStore for ephemeral sessions | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | John Wilander <wilander> | ||||||||||||||
| Component: | WebKit Misc. | Assignee: | John Wilander <wilander> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, ews-watchlist | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
John Wilander
2018-06-28 13:49:05 PDT
Created attachment 343846 [details]
Patch
Created attachment 343862 [details]
Patch
Created attachment 343863 [details]
Patch
Created attachment 343865 [details]
Patch
Comment on attachment 343865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343865&action=review LGTM, just a suggestion. > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1478 > We should probably ASSERT(!m_sessionID.isEphemeral()) here. Comment on attachment 343865 [details] Patch Attachment 343865 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8380231 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html Created attachment 343902 [details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 343865 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343865&action=review r=me, but I'm afraid you'll need to rebase your patch (after Chris's change) before you can land. > Source/WebKit/ChangeLog:9 > + Most of the changes in this patch removes the boolean parameter for tracking "Most of the changes in this patch REMOVE the boolean parameter for tracking" >> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1478 >> > > We should probably ASSERT(!m_sessionID.isEphemeral()) here. Agreed! Created attachment 343931 [details]
Patch for landing
Comment on attachment 343931 [details] Patch for landing Clearing flags on attachment: 343931 Committed r233367: <https://trac.webkit.org/changeset/233367> All reviewed patches have been landed. Closing bug. |