Summary: | Make sure the WebResourceLoadStatisticsStore gets destroyed on the main thread | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, mkwst, ryanhaddad, webkit-bug-importer, wilander, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 187055 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Chris Dumez
2018-06-28 09:37:55 PDT
Created attachment 343857 [details]
Patch
Comment on attachment 343857 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343857&action=review > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:188 > + m_statisticsQueue->dispatch([this, protectedThis = makeRef(*this), origins = WTFMove(origins)]() mutable { origins should be isolated except if we are sure they are coming straight from IPC. We should add a comment saying why this is ok. And we should probably make WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated private to ensure it does not get used out of IPC. > Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:258 > void WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener(String&& primaryDomainInNeedOfStorageAccess, uint64_t openerPageID, String&& openerPrimaryDomain, bool isTriggeredByUserGesture) Ditto. Created attachment 343868 [details]
Patch
Comment on attachment 343868 [details] Patch Clearing flags on attachment: 343868 Committed r233342: <https://trac.webkit.org/changeset/233342> All reviewed patches have been landed. Closing bug. |