Bug 18707

Summary:

SQUIRRELFISH: eval always performs toString() on its argument

Product:

WebKit

Reporter:

Cameron Zwarich (cpst) <zwarich>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

18624

Attachments:

Description	Flags
Proposed patch	mjs: review+

Description Cameron Zwarich (cpst) 2008-04-23 22:06:33 PDT

The following JavaScriptCore tests fail because eval always performs toString() on its argument, instead of returning the argument verbatim if it is not a string:

ecma/GlobalObject/15.1.2.1-1.js
ecma/NativeObjects/15-2.js
ecma/Number/15.7.3.1-2.js
ecma/ObjectObjects/15.2.3-1.js

Comment 1 Cameron Zwarich (cpst) 2008-04-23 22:19:59 PDT

Created attachment 20785 [details]
Proposed patch

Here is a patch that fixes the problem. It shows no difference on SunSpider.

Comment 2 Maciej Stachowiak 2008-04-23 22:27:30 PDT

Comment on attachment 20785 [details]
Proposed patch

r=me

Comment 3 Cameron Zwarich (cpst) 2008-04-23 22:35:52 PDT

Committed in r32459.