Bug 187058
| Summary: | Malformed contributors.json should not cause webkit-patch apply-attachment to fail; breaks EWS | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aakash_jain, ahmad.saleem792, dean_johnson, jbedard, lforschler |
| Priority: | P2 | ||
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Daniel Bates
The command "webkit-patch apply-attachment" fails when the file <https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json> is malformed. Because the EWS bots use "webkit-patch apply-attachment" they will fail to apply a patch in this case and stop processing of the patch. A malformed contributors.json should not cause this command to fail and more importantly should not cause the EWS to fail a patch.
I noticed this issue on the EWS following the landing of <https://trac.webkit.org/changeset/233209/>. This changeset contained an erroneous comma that caused contributors.json to be considered malformed JSON. Here is the output seen on EWS:
[[
Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=ews104', 'apply-attachment', '--no-update', '--non-interactive', 343619, '--port=mac-wk2']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
contributors.json is malformed: Expecting property name enclosed in double quotes: line 166 column 4 (char 3586)
]]
<https://webkit-queues.webkit.org/results/8349480>
For completeness, the syntax of contributors.json was corrected in <https://trac.webkit.org/changeset/233211/>.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Is this an issue as of today or this can be marked as resolved? Thanks!