Bug 187056

Summary: webkit-patch: Make attachment commands work with status-server hosted attachments
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ews-watchlist, glenn, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch and unit test
none
Archive of layout-test-results from ews200 for win-future none

Daniel Bates
Reported 2018-06-26 11:12:14 PDT
We should teach "webkit-patch apply-attachment" and other attachment-processing commands (*) how to fetch attachments from the status server when it cannot access them from Bugzilla due to a permission error. Note that the status server will only allow a person to fetch such attachments with a valid API key. (*) apply-watchlist, build-attachment, build-and-test-attachment, check-style and land-attachment
Attachments
Patch and unit test (10.71 KB, patch)
2018-06-26 11:24 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (12.92 MB, application/zip)
2018-06-26 13:20 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-06-26 11:16:50 PDT
Although a human being can make use of these commands to work with status-server hosted attachments the primary audience for this change are the EWS bots. The EWS bots invoke webkit-patch to perform attachment operations.
Daniel Bates
Comment 2 2018-06-26 11:24:39 PDT
Created attachment 343625 [details] Patch and unit test
EWS Watchlist
Comment 3 2018-06-26 13:20:45 PDT
Comment on attachment 343625 [details] Patch and unit test Attachment 343625 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8350076 New failing tests: http/tests/security/video-poster-cross-origin-crash2.html
EWS Watchlist
Comment 4 2018-06-26 13:20:57 PDT
Created attachment 343633 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Per Arne Vollan
Comment 5 2018-06-26 13:49:27 PDT
Comment on attachment 343625 [details] Patch and unit test R=me.
Daniel Bates
Comment 6 2018-06-26 13:54:58 PDT
Comment on attachment 343625 [details] Patch and unit test Clearing flags on attachment: 343625 Committed r233219: <https://trac.webkit.org/changeset/233219>
Daniel Bates
Comment 7 2018-06-26 13:55:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-06-26 13:56:18 PDT
<rdar://problem/41489194>
Note You need to log in before you can comment on or make changes to this bug.