Bug 18705

Summary: [GTK] WebView emits warnings for subclass properties
Product: WebKit Reporter: Christian Dywan <christian>
Component: WebKitGTKAssignee: Christian Dywan <christian>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Gtk
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Check for valid properties alp: review+

Christian Dywan
Reported 2008-04-23 16:03:06 PDT
The WebView updates settings via "notify" signals from WebSettings and tests the property name for a known string, otherwise it emits a warning. This results in wrong warnings if WebSettings is subclassed in an application and assigned to a WebView. Current git versions of midori will trigger this wrong behavior because MidoriWebSettings has a number of additional properties which the WebView doesn't know about.
Attachments
Check for valid properties (1.23 KB, patch)
2008-04-23 16:05 PDT, Christian Dywan 		alp: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Christian Dywan
Comment 1 2008-04-23 16:05:08 PDT
Created attachment 20782 [details] Check for valid properties This patch lets the WebView check if the property is valid even if it doesn't know about it, and only if that is not the case emits a warning.
Alp Toker
Comment 2 2008-04-23 20:09:32 PDT
Comment on attachment 20782 [details] Check for valid properties r=me but please remove the space after G_OBJECT_GET_CLASS before landing.
Christian Dywan
Comment 3 2008-04-24 01:21:06 PDT
Landed in r32465.
Note You need to log in before you can comment on or make changes to this bug.