Summary: | [gtk] cannot type letters with dead keys in textarea | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | arno. <a.renevier> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | alp, ap | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
arno.
2008-04-23 15:30:46 PDT
Created attachment 20780 [details]
calls doTextFieldCommandFromEvent on keydown for textareas
Upgrading to P1. ap, any thoughts on whether this patch is correct? Comment on attachment 20780 [details]
calls doTextFieldCommandFromEvent on keydown for textareas
WebEditorClient::doTextFieldCommandFromEvent() is really only about text fields, which textareas are not. Invoking it for text areas would break Safari on the Mac, besides not being true to its name.
We could of course add another client method just for textareas, but processing dead keys in element default handlers doesn't seem right to me in general, it is a much lower level task. Perhaps WebEditorClient::handleKeyboardEvent() would be more appropriate.
Created attachment 21390 [details]
Input method fixes
Comment on attachment 21390 [details]
Input method fixes
Obviously, I'm not an expert at GTK input methods, but this looks absolutely reasonable, r=me.
I would expect that this doesn't dispatch text input events in a manner compatible with IE and Safari though.
|