Bug 187038

Summary: Fix testapi build when DFG_JIT is disabled
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: New BugsAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, ryanhaddad, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mark.lam: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Archive of layout-test-results from ews200 for win-future none

Tadeu Zagallo
Reported 2018-06-26 03:23:24 PDT
Fix testapi build when DFG_JIT is disabled
Attachments
Patch (1.63 KB, patch)
2018-06-26 03:23 PDT, Tadeu Zagallo 		mark.lam: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.27 MB, application/zip)
2018-06-26 05:34 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews200 for win-future (12.94 MB, application/zip)
2018-06-26 06:40 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2018-06-26 03:23:37 PDT
Created attachment 343597 [details] Patch
EWS Watchlist
Comment 2 2018-06-26 05:33:59 PDT
Comment on attachment 343597 [details] Patch Attachment 343597 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8345947 New failing tests: svg/animations/smil-leak-dynamically-added-element-instances.svg
EWS Watchlist
Comment 3 2018-06-26 05:34:00 PDT
Created attachment 343600 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
EWS Watchlist
Comment 4 2018-06-26 06:40:31 PDT
Comment on attachment 343597 [details] Patch Attachment 343597 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8346275 New failing tests: http/tests/preload/onload_event.html
EWS Watchlist
Comment 5 2018-06-26 06:40:42 PDT
Created attachment 343601 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Ryan Haddad
Comment 6 2018-06-26 10:11:20 PDT
(In reply to Build Bot from comment #2) > Comment on attachment 343597 [details] > Patch > > Attachment 343597 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: https://webkit-queues.webkit.org/results/8345947 > > New failing tests: > svg/animations/smil-leak-dynamically-added-element-instances.svg Unrelated. (In reply to Build Bot from comment #4) > Comment on attachment 343597 [details] > Patch > > Attachment 343597 [details] did not pass win-ews (win): > Output: https://webkit-queues.webkit.org/results/8346275 > > New failing tests: > http/tests/preload/onload_event.html Unrelated.
Mark Lam
Comment 7 2018-06-26 10:24:09 PDT
Comment on attachment 343597 [details] Patch r=me
Ryan Haddad
Comment 8 2018-06-26 10:50:10 PDT
Landed in https://trac.webkit.org/changeset/233204/webkit
Radar WebKit Bug Importer
Comment 9 2018-06-26 10:54:24 PDT
<rdar://problem/41479566>
Note You need to log in before you can comment on or make changes to this bug.