Bug 187016

Summary: Simplify NetworkStorageSession::getAllStorageAccessEntries()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, commit-queue, ews-watchlist, ggaren, webkit-bug-importer, wilander, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews202 for win-future
none
Patch none

Chris Dumez
Reported 2018-06-25 14:18:15 PDT
Simplify NetworkStorageSession::getAllStorageAccessEntries().
Attachments
Patch (1.84 KB, patch)
2018-06-25 14:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews202 for win-future (12.88 MB, application/zip)
2018-06-25 20:28 PDT, EWS Watchlist 		no flags
Details
Patch (1.84 KB, patch)
2018-06-26 13:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-06-25 14:19:44 PDT
Created attachment 343537 [details] Patch
John Wilander
Comment 2 2018-06-25 14:22:47 PDT
This code is test infrastructure afaik. Tests under http/tests/storageAccess/ should ensure its functionality is maintained with this change.
Chris Dumez
Comment 3 2018-06-25 14:23:42 PDT
(In reply to John Wilander from comment #2) > This code is test infrastructure afaik. Tests under > http/tests/storageAccess/ should ensure its functionality is maintained with > this change. I verified locally that these tests still pass with my change.
EWS Watchlist
Comment 4 2018-06-25 20:27:58 PDT
Comment on attachment 343537 [details] Patch Attachment 343537 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8341339 New failing tests: http/tests/security/canvas-remote-read-remote-video-redirect.html
EWS Watchlist
Comment 5 2018-06-25 20:28:09 PDT
Created attachment 343578 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
youenn fablet
Comment 6 2018-06-26 13:30:34 PDT
Comment on attachment 343537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343537&action=review > Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:335 > + for (auto& innerPair : pair.value) Why not using HashMap::values on both for loops?
Chris Dumez
Comment 7 2018-06-26 13:40:15 PDT
Created attachment 343635 [details] Patch
Chris Dumez
Comment 8 2018-06-26 13:41:02 PDT
(In reply to youenn fablet from comment #6) > Comment on attachment 343537 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=343537&action=review > > > Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:335 > > + for (auto& innerPair : pair.value) > > Why not using HashMap::values on both for loops? Good point :D
WebKit Commit Bot
Comment 9 2018-06-26 14:42:40 PDT
Comment on attachment 343635 [details] Patch Clearing flags on attachment: 343635 Committed r233222: <https://trac.webkit.org/changeset/233222>
WebKit Commit Bot
Comment 10 2018-06-26 14:42:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2018-06-26 14:45:02 PDT
<rdar://problem/41491950>
Note You need to log in before you can comment on or make changes to this bug.