Bug 187004

Summary: Tap highlight displayed when tapping a field that is already focussed
Product: WebKit Reporter: Aditya Keerthi <pxlcoder>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: iPhone / iPad   
OS: Other   
Attachments:
Description Flags
Patch
thorton: review+
Patch none

Aditya Keerthi
Reported 2018-06-25 10:04:13 PDT
The tap highlight is displayed when tapping a field that is already focussed. This bug is present on ToT. Reproduction steps 1. Navigate to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea 2. Tap on the search field to begin an input session - this correctly displays the tap highlight 3. Tap on the field again - the tap highlight is incorrectly shown
Attachments
Patch (2.00 KB, patch)
2018-06-25 10:17 PDT, Aditya Keerthi 		thorton: review+
DetailsFormatted DiffDiff
Patch (2.09 KB, patch)
2018-06-26 14:29 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2018-06-25 10:17:11 PDT
Created attachment 343509 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-06-25 10:19:08 PDT
<rdar://problem/41428008>
Tim Horton
Comment 3 2018-06-26 11:23:58 PDT
Comment on attachment 343509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343509&action=review > Source/WebKit/ChangeLog:5 > + No Radar? > Source/WebKit/ChangeLog:9 > + _singleTapCommited: could be invoked before the tap highlight request, causing > + _potentialTapInProgress to be set to NO. This results in the early return for Really? I thought these things were all strictly ordered.
Aditya Keerthi
Comment 4 2018-06-26 14:29:57 PDT
Created attachment 343641 [details] Patch
Aditya Keerthi
Comment 5 2018-06-26 14:31:53 PDT
Added radar to the ChangeLog and explained the cause of the different ordering.
WebKit Commit Bot
Comment 6 2018-06-26 15:21:06 PDT
Comment on attachment 343641 [details] Patch Clearing flags on attachment: 343641 Committed r233225: <https://trac.webkit.org/changeset/233225>
Note You need to log in before you can comment on or make changes to this bug.