Summary: | Add API to control mock media devices | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
youenn fablet
2018-06-22 18:48:46 PDT
Created attachment 343414 [details]
Patch
Created attachment 343418 [details]
Patch
Created attachment 343441 [details]
Patch
Comment on attachment 343441 [details]
Patch
Patch is ready for a first round of review.
I need to beef-up the change log, especially the changes to MediaDevices to ensure it is not GCed while dispatching events.
Comment on attachment 343441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343441&action=review > Source/WebKit/UIProcess/API/C/WKMockMediaDevice.cpp:48 > +static inline std::optional<Properties> typeFromString(const String& type) > +{ > + if (type == "camera") > + return Properties { WebCore::MockCameraProperties { } }; > + if (type == "microphone") > + return Properties { WebCore::MockMicrophoneProperties { } }; > + if (type == "screen") > + return Properties { WebCore::MockDisplayProperties { } }; > + return std::nullopt; > +} Nit: this is only used in one place. Is there a plan to use it in more place? Created attachment 343508 [details]
Patch for landing
Created attachment 343517 [details]
Patch for landing
Comment on attachment 343517 [details] Patch for landing Clearing flags on attachment: 343517 Committed r233162: <https://trac.webkit.org/changeset/233162> All reviewed patches have been landed. Closing bug. |