Bug 186937

Summary: [Mac] Web Automation: include correct key code with synthesized NSEvents used for keystrokes
Product: WebKit Reporter: Brian Burg <bburg>
Component: WebDriverAssignee: Brian Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cgarcia, ews-watchlist, joepeck, rniwa, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews105 for mac-sierra-wk2 none

Description Brian Burg 2018-06-22 12:45:44 PDT
Currently the code only computes these for VirtualKeys, but key codes exist for ASCII letters as well.
Comment 1 Brian Burg 2018-06-22 12:50:22 PDT
Created attachment 343357 [details]
Patch
Comment 2 Brian Burg 2018-06-24 18:13:08 PDT
Created attachment 343472 [details]
Patch
Comment 3 EWS Watchlist 2018-06-24 19:38:17 PDT
Comment on attachment 343472 [details]
Patch

Attachment 343472 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8317819

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2018-06-24 19:38:19 PDT
Created attachment 343473 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 Brian Burg 2018-06-25 09:22:13 PDT
Committed r233149: <https://trac.webkit.org/changeset/233149>
Comment 6 Radar WebKit Bug Importer 2018-06-25 09:23:23 PDT
<rdar://problem/41426265>