Bug 186928

Summary: We should call visitChildren on Base not the exact typename
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing keith_miller: commit-queue+

Keith Miller
Reported 2018-06-22 10:01:22 PDT
GetterSetter should call visitChildren on Base not JSCell
Attachments
Patch (18.56 KB, patch)
2018-06-22 10:26 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.56 KB, patch)
2018-06-22 10:33 PDT, Keith Miller 		keith_miller: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2018-06-22 10:26:03 PDT
Created attachment 343337 [details] Patch
Mark Lam
Comment 2 2018-06-22 10:32:12 PDT
Comment on attachment 343337 [details] Patch r=me
Keith Miller
Comment 3 2018-06-22 10:33:28 PDT
Created attachment 343340 [details] Patch for landing
Keith Miller
Comment 4 2018-06-22 11:26:46 PDT
Committed r233085: <https://trac.webkit.org/changeset/233085>
Radar WebKit Bug Importer
Comment 5 2018-06-22 11:27:21 PDT
<rdar://problem/41375075>
Note You need to log in before you can comment on or make changes to this bug.